fix: types: ensure .Amount is non-nil in Coin.Validate() #15691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
mark-rushakoff and
facundomedica
and removed request for
a team
This comment has been minimized.
This comment has been minimized.
odeke-em
force-pushed
the
types-make-Coin.Validate-check-for-non-nil-Amount
branch
3 times, most recently
from
5217ed6 to
6a7d94c
Compare
odeke-em
force-pushed
the
types-make-Coin.Validate-check-for-non-nil-Amount
branch
from
6a7d94c to
3bab1c8
Compare
odeke-em
force-pushed
the
types-make-Coin.Validate-check-for-non-nil-Amount
branch
from
3bab1c8 to
268429c
Compare
|
Kindly cc-ing @julienrbrt for a review too. Thank you |
This change fixes a scenario in which Coin.Validate() would panic when given a nil Amount. While here, added a fuzz test along with unit/regression tests. Found and reported by the Quicksilver team. Fixes #15690
odeke-em
force-pushed
the
types-make-Coin.Validate-check-for-non-nil-Amount
branch
from
268429c to
c95c6c7
Compare
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a scenario in which Coin.Validate() would panic when given a nil Amount. While here, added a fuzz test along with unit/regression tests.
Fixes #15690