golint + general cleanup #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melekes
approved these changes
Jul 5, 2017
app/genesis.go
Outdated
| @@ -8,6 +8,7 @@ import ( | |||
| cmn "github.com/tendermint/tmlibs/common" | |||
| ) | |||
|
|
|||
| // LoadGenesis - Load the genesis json file | |||
There was a problem hiding this comment.
I'd prefer LoadGenesis loads the genesis file into memory (the same style is used in stdlib)
ParthDesai
pushed a commit
to ChorusOne/cosmos-sdk
that referenced
this pull request
Apr 19, 2021
alexanderbez
pushed a commit
that referenced
this pull request
Apr 5, 2022
* implement store proof and commit hash query * move proods query to a separate function * update multistore Query comment
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only partially though, but should merge this PR so you can work more on it. Will pick up tomorrow again.
Many small cleanups - also setting up for golint. If there are changes you want to make before merging please feel free to push them np.
Core work in this PR is to: