refactor(bank): migrate bech32 encoding #15567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:Simulations
C:x/bank
C:x/genutil
19 tasks
tac0turtle
commented
Apr 7, 2023
x/bank/exported/exported.go
Outdated
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| paramtypes "github.com/cosmos/cosmos-sdk/x/params/types" | ||
| ) | ||
|
|
||
| // GenesisBalance defines a genesis balance interface that allows for account | ||
| // address and balance retrieval. | ||
| type GenesisBalance interface { | ||
| GetAddress() sdk.AccAddress | ||
| GetAddress(address.Codec) ([]byte, error) |
There was a problem hiding this comment.
this is causing a lot of breakage, not sure how to avoid it. Anyone have ideas
There was a problem hiding this comment.
Why not handle this logic in the genesis functions and return string here?
aaronc
reviewed
Apr 7, 2023
x/bank/exported/exported.go
Outdated
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| paramtypes "github.com/cosmos/cosmos-sdk/x/params/types" | ||
| ) | ||
|
|
||
| // GenesisBalance defines a genesis balance interface that allows for account | ||
| // address and balance retrieval. | ||
| type GenesisBalance interface { | ||
| GetAddress() sdk.AccAddress | ||
| GetAddress(address.Codec) ([]byte, error) |
There was a problem hiding this comment.
Why not handle this logic in the genesis functions and return string here?
julienrbrt
reviewed
May 2, 2023
tac0turtle
changed the title
github-prbot
requested review from
a team,
kocubinski and
facundomedica
and removed request for
a team
julienrbrt
reviewed
May 22, 2023
julienrbrt
reviewed
May 22, 2023
alexanderbez
approved these changes
May 24, 2023
aaronc
reviewed
May 24, 2023
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove bech32 encoding from bank. Replaces previous pr due to issues with merge conflicts
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change