Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: use KVStoreService in x/consensus #15517

Merged
merged 20 commits into from
Mar 23, 2023
Merged

Conversation

facundomedica
Copy link
Member

@facundomedica facundomedica commented Mar 22, 2023

Description

A small PR progressing towards Core API. Here instead of passing the StoreKey we take a KVStoreService


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot removed the C:CLI label Mar 22, 2023
@facundomedica facundomedica marked this pull request as ready for review March 22, 2023 20:03
@facundomedica facundomedica requested a review from a team as a code owner March 22, 2023 20:03
@github-prbot github-prbot requested review from a team, JeancarloBarrios and testinginprod and removed request for a team March 22, 2023 20:03
@facundomedica
Copy link
Member Author

Should I also return the errors instead of panicking? This would change baseapp's ParamStore interface. Then we can just panic when calling StoreConsensusParams if an error is returned

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE IT

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we need a changelog and an UPGRADING.md section for explaining what to change for people not using app wiring.

@facundomedica facundomedica enabled auto-merge (squash) March 23, 2023 15:16
@julienrbrt julienrbrt added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 23, 2023
@facundomedica facundomedica merged commit aeb4f02 into main Mar 23, 2023
@facundomedica facundomedica deleted the facu/cons-storesvc branch March 23, 2023 17:03
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants