Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(feegrant): remove bech32 global #15347

Merged
merged 34 commits into from
Mar 24, 2023
Merged

refactor(feegrant): remove bech32 global #15347

merged 34 commits into from
Mar 24, 2023

Conversation

tac0turtle
Copy link
Member

Description

ref #13140

remove global bech32 usage from feegrant

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Mar 10, 2023
@tac0turtle
Copy link
Member Author

tac0turtle commented Mar 17, 2023 •
edited
Loading

opening this up for review, but wondering if i should remove the usage of sdk.Accaddress as well?

cc @aaronc

@tac0turtle tac0turtle marked this pull request as ready for review March 17, 2023 13:49
@tac0turtle tac0turtle requested a review from a team as a code owner March 17, 2023 13:49
@github-prbot github-prbot requested review from a team, kocubinski and atheeshp and removed request for a team March 17, 2023 13:50
aaronc
aaronc reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sort of split as to whether we should find a way to put address.Codec on codec.Codec. It sort of doesn't belong there. And it would also be really convenient for refactoring...

@tac0turtle
Copy link
Member Author

tac0turtle commented Mar 20, 2023 •
edited
Loading

I'm sort of split as to whether we should find a way to put address.Codec on codec.Codec. It sort of doesn't belong there. And it would also be really convenient for refactoring...

the main issue i see with this is that codec.Codec is technically optional in some modules, for example circuit. This would make it required. Im fine either way but prefer to not conflate two things like data encoding/decoding with simple addess encoding/decoding

alexanderbez
alexanderbez approved these changes Mar 20, 2023
View reviewed changes
testutil/bech32_codec.go Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

@tac0turtle your pull request is missing a changelog!

julienrbrt
julienrbrt reviewed Mar 21, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, few questions on the changes in validate basics.

tests/e2e/feegrant/suite.go Show resolved Hide resolved
x/feegrant/msgs.go Show resolved Hide resolved
x/feegrant/msgs.go Show resolved Hide resolved
amaury1093
amaury1093 approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe just missing a changelog

@julienrbrt
Copy link
Member

Feegrant tests are failing: https://github.com/cosmos/cosmos-sdk/actions/runs/4490038334/jobs/7896619682?pr=15347

@tac0turtle tac0turtle enabled auto-merge (squash) March 24, 2023 09:25
@tac0turtle tac0turtle disabled auto-merge March 24, 2023 10:31
@julienrbrt julienrbrt changed the title refactor: feegrant: remove bech32 global refactor(feegrant): remove bech32 global Mar 24, 2023
@julienrbrt
Copy link
Member

Test now ok: https://github.com/cosmos/cosmos-sdk/actions/runs/4513621099/jobs/7948701383?pr=15347
Putting automerge.

@julienrbrt julienrbrt enabled auto-merge (squash) March 24, 2023 17:16
@julienrbrt julienrbrt merged commit 572e657 into main Mar 24, 2023
@julienrbrt julienrbrt deleted the marko/bech32_global_feegrant branch March 24, 2023 22:33
@faddat faddat mentioned this pull request Mar 28, 2023
Closed
19 tasks
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@tac0turtle @julienrbrt
refactor(feegrant): remove bech32 global (cosmos#15347)
ec60c5c 
Co-authored-by: Julien Robert <[email protected]>
@coderabbitai coderabbitai bot mentioned this pull request Apr 22, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@aaronc aaronc aaronc left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

@atheeshp atheeshp Awaiting requested review from atheeshp

Assignees
No one assigned
Labels
C:CLI C:Simulations C:x/auth C:x/feegrant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tac0turtle @julienrbrt @aaronc @amaury1093 @alexanderbez