Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use Custom Priority in Priority Nonce Mempool #15328

Merged
merged 12 commits into from
Mar 15, 2023
Merged

refactor: Use Custom Priority in Priority Nonce Mempool #15328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3a9e058
updates
alexanderbez Mar 9, 2023
d6ccf21
Merge branch 'main' into bez/mempool-improved-priority
alexanderbez Mar 9, 2023
cfb34d9
Merge branch 'main' into bez/mempool-improved-priority
alexanderbez Mar 13, 2023
4545488
generics approach
alexanderbez Mar 14, 2023
9c6fa72
Merge branch 'main' into bez/mempool-improved-priority
alexanderbez Mar 14, 2023
84e5fd8
Merge branch 'main' into bez/mempool-improved-priority
alexanderbez Mar 14, 2023
3b0a632
updates
alexanderbez Mar 14, 2023
9615a7a
Merge branch 'bez/mempool-improved-priority' of github.com:cosmos/cos…
alexanderbez Mar 14, 2023
c78e63b
Merge branch 'main' into bez/mempool-improved-priority
alexanderbez Mar 14, 2023
a892940
updates
alexanderbez Mar 14, 2023
d52e1a9
Merge branch 'main' into bez/mempool-improved-priority
alexanderbez Mar 15, 2023
08ee562
updates
alexanderbez Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Improvements

* (mempool) [#15328](https://github.com/cosmos/cosmos-sdk/pull/15328) Improve the `PriorityNonceMempool`
* Support generic transaction prioritization, instead of `ctx.Priority()`
* Improve construction through the use of a single `PriorityNonceMempoolConfig` instead of option functions
* (x/authz) [#15164](https://github.com/cosmos/cosmos-sdk/pull/15164) Add `MsgCancelUnbondingDelegation` to staking authorization
* (server) [#15358](https://github.com/cosmos/cosmos-sdk/pull/15358) Add `server.InterceptConfigsAndCreateContext` as alternative to `server.InterceptConfigsPreRunHandler` which does not set the server context and the default SDK logger.
* [#15011](https://github.com/cosmos/cosmos-sdk/pull/15011) Introduce `cosmossdk.io/log` package to provide a consistent logging interface through the SDK. CometBFT logger is now replaced by `cosmossdk.io/log.Logger`.
Expand Down Expand Up @@ -97,6 +100,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### API Breaking Changes

* (mempool) [#15328](https://github.com/cosmos/cosmos-sdk/pull/15328) The `PriorityNonceMempool` is now generic over type `C comparable` and takes a single `PriorityNonceMempoolConfig[C]` argument. See `DefaultPriorityNonceMempoolConfig` for how to construct the configuration and a `TxPriority` type.
* (server) [#15358](https://github.com/cosmos/cosmos-sdk/pull/15358) Remove `server.ErrorCode` that was not used anywhere.
* [#15211](https://github.com/cosmos/cosmos-sdk/pull/15211) Remove usage of `github.com/cometbft/cometbft/libs/bytes.HexBytes` in favor of `[]byte` thorough the SDK.
* [#15011](https://github.com/cosmos/cosmos-sdk/pull/15011) All functions that were taking a CometBFT logger, now take `cosmossdk.io/log.Logger` instead.
Expand Down
Loading