Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: deprecate sdk.Msg.GetSigners #15284

Merged
merged 111 commits into from
May 25, 2023
Merged
Changes from 1 commit
Commits
Show all changes
111 commits
Select commit Hold shift + click to select a range
ea8ed7e
refactor!: deprecate sdk.Msg.GetSigners
aaronc Mar 6, 2023
e45bc3e
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc Mar 6, 2023
20615e7
reduce scope
aaronc Mar 6, 2023
f303a94
reduce scope
aaronc Mar 6, 2023
dae1e0b
WIP
aaronc Mar 6, 2023
4ee2bd2
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc Mar 7, 2023
5f78ad0
refactoring
aaronc Mar 7, 2023
d3aa37c
refactoring
aaronc Mar 7, 2023
924c22d
refactoring
aaronc Mar 7, 2023
7828f38
refactoring
aaronc Mar 7, 2023
a1d35d2
tests compile
aaronc Mar 7, 2023
46d9580
interface registry serves proto files
aaronc Mar 7, 2023
ec48afd
WIP on moving to codec
aaronc Mar 7, 2023
43eab5f
refactor to codec-based API
aaronc Mar 7, 2023
e634695
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc Mar 7, 2023
c262872
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc Mar 13, 2023
a63d8b5
WIP update to anyutil
aaronc Mar 13, 2023
a33c098
WIP
aaronc Mar 13, 2023
a9d12bc
building
aaronc Mar 13, 2023
4c3e334
start removing GetSigners
aaronc Mar 13, 2023
d86f868
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc Mar 15, 2023
5474a26
Revert "start removing GetSigners"
aaronc Mar 15, 2023
65050eb
fix
aaronc Mar 15, 2023
9541220
update CHANGELOG.md and remove some breakage
aaronc Mar 15, 2023
aa21cea
update CHANGELOG.md and update some breakage
aaronc Mar 15, 2023
c67dace
update runtime module
aaronc Mar 15, 2023
4b5de9e
updates
aaronc Mar 15, 2023
4d412da
fix
aaronc Mar 15, 2023
6c4cb00
test fix
aaronc Mar 15, 2023
8ac184a
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc Mar 15, 2023
161ab16
update x/tx dep
aaronc Mar 15, 2023
1d0cabe
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc Mar 28, 2023
840e106
update runtime
aaronc Mar 28, 2023
20e97d7
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc Mar 28, 2023
1c91539
WIP
aaronc Mar 28, 2023
20d581d
WIP
aaronc Mar 28, 2023
c0ee235
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc Mar 29, 2023
82ba59e
update x/tx
aaronc Mar 29, 2023
b124bd6
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc Apr 3, 2023
e5b17aa
WIP on bug fixes
aaronc Apr 3, 2023
ad6af68
refactor sdk.AccAddress usages to string
aaronc Apr 3, 2023
b618ad4
refactor MsgCreateValidator.validator_address to use account address
aaronc Apr 3, 2023
843f04f
test fixes
aaronc Apr 3, 2023
4255b82
migrate MsgUnjail to use account bech32
aaronc Apr 3, 2023
1453302
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc Apr 12, 2023
1b8cfe2
WIP on refactoring
aaronc Apr 12, 2023
ffbcb80
WIP on refactoring
aaronc Apr 12, 2023
46a5f38
refactor codec & interface registry
aaronc Apr 13, 2023
975cba0
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc Apr 13, 2023
0c7fb0b
revert staking and slashing changes
aaronc Apr 13, 2023
11c37bd
building
aaronc Apr 17, 2023
5d8e489
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc Apr 18, 2023
edce178
revert
aaronc Apr 18, 2023
074e25e
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc May 1, 2023
c8de238
fixes
aaronc May 1, 2023
3160c6d
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc May 3, 2023
2415235
add codec testutil
aaronc May 3, 2023
b8e7e96
test fixes
aaronc May 3, 2023
6452dc0
fix test
aaronc May 3, 2023
b17adc2
test fixes
aaronc May 3, 2023
70c1a85
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc May 3, 2023
5e45f37
test fixes
aaronc May 3, 2023
2c038a9
test fixes
aaronc May 3, 2023
59dddfe
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc May 4, 2023
3bb3a14
fixes
aaronc May 4, 2023
641457c
fixes
aaronc May 4, 2023
50a6ec1
fixes
aaronc May 4, 2023
00205a5
fixes
aaronc May 4, 2023
15ff7e9
fix rosetta
aaronc May 4, 2023
d7781cd
Merge branch 'main' into aaronc/11275-deprecate-get-signers-2
aaronc May 4, 2023
f2bbf36
fixes
aaronc May 4, 2023
227a0a6
test fixes
aaronc May 4, 2023
0a216cc
make ante.HandlerOptions.SigningContext optional
aaronc May 4, 2023
5822abc
update CHANGELOG.md
aaronc May 4, 2023
53d93e8
return errors
aaronc May 4, 2023
9d69fa5
don't panic
aaronc May 4, 2023
0459d10
fixes
aaronc May 4, 2023
0b9432c
lint
aaronc May 4, 2023
9fe7984
lint
aaronc May 4, 2023
3ad191b
lint
aaronc May 4, 2023
8bf26db
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc May 8, 2023
195349e
Update baseapp/baseapp.go
aaronc May 9, 2023
cdc0d9c
address review comments
aaronc May 9, 2023
81faf2b
address review comments
aaronc May 9, 2023
2633439
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc May 11, 2023
136811a
add `AccountKeeper.AddressCodec()` method
aaronc May 11, 2023
e2d668a
fix tests
aaronc May 11, 2023
8c22d9a
add benchmark
aaronc May 16, 2023
9d16ef2
add dynamicpb bench
aaronc May 16, 2023
d01b0e8
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc May 16, 2023
e033c04
fix simapp tests (#16185)
kocubinski May 16, 2023
077e202
address review comments
aaronc May 16, 2023
7624c4e
Merge remote-tracking branch 'origin/aaronc/11275-deprecate-get-signe…
aaronc May 16, 2023
2002843
fix comment in linter
kocubinski May 17, 2023
a13f253
Register Tx with HasMsg interface
kocubinski May 17, 2023
04f8c52
Fix some e2e tests
kocubinski May 17, 2023
a3527c8
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc May 23, 2023
8538e0e
fix
aaronc May 24, 2023
ece6e65
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc May 24, 2023
72ccc72
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc May 24, 2023
5040e7e
fix test
aaronc May 24, 2023
4b8d176
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc May 24, 2023
d37b395
fix rosetta, simplify runtime
aaronc May 24, 2023
9b6be9f
fix amino
aaronc May 24, 2023
343c3ca
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc May 24, 2023
9b1be48
fix test
aaronc May 24, 2023
7c2b7cc
check error
aaronc May 24, 2023
bd63b84
fix acc_seq event
aaronc May 24, 2023
ddf4e73
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/11275…
aaronc May 25, 2023
b41ab3f
use address.Bech32Codec in simapp
aaronc May 25, 2023
85129fd
address review comment
aaronc May 25, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
aaronc committed May 24, 2023
commit 5040e7e0dfc1a1190510141c66106f8f4d42e697
11 changes: 6 additions & 5 deletions baseapp/abci_test.go
Original file line number Diff line number Diff line change
@@ -11,16 +11,17 @@ import (
errorsmod "cosmossdk.io/errors"
"cosmossdk.io/log"

pruningtypes "cosmossdk.io/store/pruning/types"
"cosmossdk.io/store/snapshots"
snapshottypes "cosmossdk.io/store/snapshots/types"
storetypes "cosmossdk.io/store/types"
abci "github.com/cometbft/cometbft/abci/types"
cmtproto "github.com/cometbft/cometbft/proto/tendermint/types"
dbm "github.com/cosmos/cosmos-db"
"github.com/cosmos/gogoproto/jsonpb"
"github.com/stretchr/testify/require"

pruningtypes "cosmossdk.io/store/pruning/types"
"cosmossdk.io/store/snapshots"
snapshottypes "cosmossdk.io/store/snapshots/types"
storetypes "cosmossdk.io/store/types"

"github.com/cosmos/cosmos-sdk/baseapp"
baseapptestutil "github.com/cosmos/cosmos-sdk/baseapp/testutil"
"github.com/cosmos/cosmos-sdk/testutil"
@@ -1253,7 +1254,7 @@ func TestABCI_PrepareProposal_ReachedMaxBytes(t *testing.T) {
}
resPrepareProposal, err := suite.baseApp.PrepareProposal(&reqPrepareProposal)
require.NoError(t, err)
require.Equal(t, 11, len(resPrepareProposal.Txs))
require.Equal(t, 8, len(resPrepareProposal.Txs))
}

func TestABCI_PrepareProposal_BadEncoding(t *testing.T) {