-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove bytes/HexBytes #15211
Conversation
I can not remove only one place,follow : because I need to modify package of cometbft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super nice docs, it looks good to me. It doesnt seem like we use the json encoding anywhere i can see.
It seems that cmtbytes does not use func of MarshalJSON() nor UnmarshalJSON(), only use of the func String(), so that I do not use json encoding. |
Note: |
@facundomedica I have made a bench test, func Benchmark_Hex(b *testing.B) { func Benchmark_Shex(b *testing.B) { goos: darwin It seems that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! We can fix the proto lint and some other things in a follow-up.
Thank you!
@@ -7,14 +7,18 @@ This guide provides instructions for upgrading to specific versions of Cosmos SD | |||
### Migration to CometBFT (Part 2) | |||
|
|||
The Cosmos SDK has migrated in, its previous versions, to CometBFT. | |||
Some functions have been renamed to reflect the naming change. | |||
Some functions have been renamed to reflect the naming change. And the Cosmos SDK has removed the import of cmtbytes "github.com/cometbft/cometbft/libs/bytes". | |||
There is something changed.Due to the import changes, this is a breaking change. Chains need to remove **entirely** their imports in their codebase, from direct and indirects imports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is something changed.Due to the import changes, this is a breaking change. Chains need to remove **entirely** their imports in their codebase, from direct and indirects imports. | |
There is something changed. Due to the import changes, this is a breaking change. Chains need to remove **entirely** their imports in their codebase, from direct and indirects imports. |
I am going to merge this now (we can improve in a follow-up). |
Description
Closes: #15049
this pr has removed bytes/HexBytes in cosmos-sdk
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change