-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate to CometBFT in v0.47 #15060
Conversation
To go further, we need the release/v0.19.x of IAVL to remove it's |
As discussed, we are going to use the IAVL v0.20.x line after this PR (cosmos/iavl#683), as we cannot remove the TM deps in the v0.19.x as hopped here: #15060 (comment). No more code change is going to happen here, except the bump to a tagged version of IAVL and CometBFT. So it can already be reviewed (but it's still blocked). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
ref: #14870
No migration to cometbft/cometbft-db and still using tendermint/tm-db, other we need IAVL to migrate in a point version too (and thus use cometbft/cometbft-db in v0.45 and v0.46 as well)Migration tocometbft/cometbft-db
done in IAVL, so done here.(https://github.com/cosmos/cosmos-sdk/actions/runs/4204024282/jobs/7294151595)
TODO (follow-ups)
Use that tag as base for toolings in main(this may not be possible)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change