Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support BlockGasMeter in prepareproposal/processproposal #14984

Closed
wants to merge 2 commits into from

Conversation

JayT106
Copy link
Contributor

@JayT106 JayT106 commented Feb 9, 2023

Description

The SDK v0.47 introduced two new methods in ABCI 1.0, prepareproposal and processproposal. Currently, the default handlers only support picking up transactions until hit the transaction bytes limit.

Therefore, if we need the validator to propose a new block with transactions based on transaction gas usage. We will need the transaction gasInfo returns from the antiHandlers within prepareproposal handler and processproposal handler. In the meantime, the new ABCI methods will need the BlockGasMeter to handle the transaction picking-up logic in the proposal handlers.

This PR I think also a prerequisite if we would like to solve #2150


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@JayT106 JayT106 requested a review from a team as a code owner February 9, 2023 19:11
@github-prbot github-prbot requested review from a team, amaury1093 and tac0turtle and removed request for a team February 9, 2023 19:11
@JayT106 JayT106 changed the title feat: support blockGasLimit in prepareproposal/processproposal feat: support BlockGasMeter in prepareproposal/processproposal Feb 9, 2023
@JayT106
Copy link
Contributor Author

JayT106 commented Feb 13, 2023

close PR due to issue already addressed in #15012

@JayT106 JayT106 closed this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant