Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add merged registry for gogo and protov2 #14886

Merged
merged 21 commits into from
Feb 20, 2023
Merged

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Feb 2, 2023

Description

Closes: #14693

Tests gogoproto's new feature for adding a merged registry cosmos/gogoproto#37.

TODO :


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@amaury1093 amaury1093 force-pushed the am/14693-single-registry branch from 5cfcb2f to 4c8f372 Compare February 13, 2023 13:20
baseapp/a/a_test.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@github-actions github-actions bot added C:Cosmovisor Issues and PR related to Cosmovisor C:Hubl Tool: Hubl C:Rosetta Issues and PR related to Rosetta C:x/evidence C:x/feegrant C:x/nft C:x/upgrade labels Feb 16, 2023
@github-actions github-actions bot added the C:Confix Issues and PR related to Confix label Feb 16, 2023
@amaury1093 amaury1093 marked this pull request as ready for review February 20, 2023 10:30
@amaury1093 amaury1093 requested a review from a team as a code owner February 20, 2023 10:30
@github-prbot github-prbot requested review from a team, julienrbrt and atheeshp and removed request for a team February 20, 2023 10:30
@amaury1093
Copy link
Contributor Author

Is test-hubl enough to assure that hubl continues to work? If not, how can I manually test it?

@amaury1093
Copy link
Contributor Author

Tested manually hubl hub query runtime reflection file-descriptors against a local node, it seems to return the correct file descriptors.

@amaury1093 amaury1093 enabled auto-merge (squash) February 20, 2023 15:13
@amaury1093 amaury1093 merged commit 96876f8 into main Feb 20, 2023
@amaury1093 amaury1093 deleted the am/14693-single-registry branch February 20, 2023 15:24
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Hubl Tool: Hubl C:Rosetta Issues and PR related to Rosetta C:x/circuit C:x/evidence C:x/feegrant C:x/nft C:x/upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merged file descriptors from gogo and protoreflect
2 participants