refactor(orm)!: support core store API #14796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronc
commented
Jan 27, 2023
Comment on lines
-61
to
-75
|
|
||
| // STORAGE_TYPE_INDEX indicates persistent storage which is not backed | ||
| // by a merkle-tree and won't affect the app hash. Note that the Cosmos SDK | ||
| // before store/v2alpha1 does not support this. | ||
| STORAGE_TYPE_INDEX = 3; | ||
|
|
||
| // STORAGE_TYPE_INDEX indicates persistent storage which is backed by | ||
| // a merkle-tree. With this type of storage, both primary and index keys | ||
| // will affect the app hash and this is generally less efficient | ||
| // than using STORAGE_TYPE_DEFAULT_UNSPECIFIED which separates index | ||
| // keys into index storage. Note that modules built with the | ||
| // Cosmos SDK before store/v2alpha1 must specify STORAGE_TYPE_COMMITMENT | ||
| // instead of STORAGE_TYPE_DEFAULT_UNSPECIFIED or STORAGE_TYPE_INDEX | ||
| // because this is the only type of persistent storage available. | ||
| STORAGE_TYPE_COMMITMENT = 4; |
There was a problem hiding this comment.
Removing these because store v2 work never completed as planned
github-prbot
requested review from
a team,
amaury1093 and
facundomedica
and removed request for
a team
tac0turtle
approved these changes
Jan 27, 2023
19 tasks
tsenart
pushed a commit
to meka-dev/cosmos-sdk
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small refactor to support the new core store API in orm, which should make it a bit easier to instantiate an
orm.ModuleDBfor a module removing one stumbling block.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change