refactor: migrate calls from alias file to appropriate store/types #14455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:collections
C:Store
C:x/auth
C:x/authz
C:x/bank
C:x/capability
C:x/consensus
C:x/crisis
C:x/distribution
|
@tac0turtle please take a look, thanks. |
tac0turtle
reviewed
Jan 2, 2023
tac0turtle
reviewed
Jan 2, 2023
julienrbrt
reviewed
Jan 3, 2023
types/store_test.go
Outdated
| @@ -57,19 +56,19 @@ func (s *storeTestSuite) TestCommitID() { | |||
| } | |||
|
|
|||
| func (s *storeTestSuite) TestNewTransientStoreKeys() { | |||
There was a problem hiding this comment.
+1, could you check? Otherwise we should move those tests in the store package.
| @@ -10,28 +10,27 @@ import ( | |||
| pruningtypes "github.com/cosmos/cosmos-sdk/store/pruning/types" | |||
| snapshottypes "github.com/cosmos/cosmos-sdk/store/snapshots/types" | |||
| storetypes "github.com/cosmos/cosmos-sdk/store/types" | |||
| sdk "github.com/cosmos/cosmos-sdk/types" | |||
There was a problem hiding this comment.
Maybe we could delete that package and replace it by gomocks (does not have to be here)?
|
@julienrbrt @likhita-809 are you fine with merging this and then I follow up in a separate pr with your suggestions? |
That works for me! Thanks! |
|
actually fixed in this pr. |
tac0turtle
reviewed
Jan 10, 2023
| @@ -189,6 +189,7 @@ replace ( | |||
| github.com/99designs/keyring => github.com/cosmos/keyring v1.2.0 | |||
| // Simapp always use the latest version of the cosmos-sdk | |||
| github.com/cosmos/cosmos-sdk => ../. | |||
| github.com/cosmos/cosmos-sdk/x/nft => .././x/nft | |||
There was a problem hiding this comment.
will remove after this pr is merged
tac0turtle
reviewed
Jan 10, 2023
| @@ -187,4 +187,5 @@ replace ( | |||
| // Fix upstream GHSA-h395-qcrw-5vmq vulnerability. | |||
| // TODO Remove it: https://github.com/cosmos/cosmos-sdk/issues/10409 | |||
| github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.8.1 | |||
| github.com/cosmos/cosmos-sdk/x/nft => .././x/nft // todo remove after pr merged | |||
There was a problem hiding this comment.
will remove after this pr is merged
|
lgtm! Could your follow-up @tac0turtle fix the golangci-lint issues too? |
julienrbrt
approved these changes
Jan 10, 2023
0xbala-k
pushed a commit
to 0xbala-k/cosmos-sdk
that referenced
this pull request
Jan 12, 2023
…osmos#14455) Co-authored-by: Marko <[email protected]> Closes cosmos#14406
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
…osmos#14455) Co-authored-by: Marko <[email protected]> Closes cosmos#14406
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #14406
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change