Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: standalone rosetta command #14118

Merged
merged 19 commits into from
Dec 7, 2022
Merged

feat: standalone rosetta command #14118

merged 19 commits into from
Dec 7, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Dec 1, 2022 •
edited
Loading

Description

Closes: #14108
depends on #14087
blocked on #13513 (comment) / #14123

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:Rosetta Issues and PR related to Rosetta Type: Build Type: CI labels Dec 1, 2022
@tac0turtle
Copy link
Member

after this change we should make a version of rosetta work with 0.46 & 0.45 then release that as well in order to allow users to do this today

@julienrbrt julienrbrt marked this pull request as ready for review December 1, 2022 15:33
@julienrbrt julienrbrt requested a review from a team as a code owner December 1, 2022 15:33
tac0turtle
tac0turtle approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@tac0turtle tac0turtle enabled auto-merge (squash) December 2, 2022 20:01
@julienrbrt julienrbrt disabled auto-merge December 5, 2022 14:30
@julienrbrt
Copy link
Member Author

Seems like we still have some indirect dependency on an old version of btcd. At least we're one step closer. Investigating...

alexanderbez
alexanderbez approved these changes Dec 6, 2022
View reviewed changes
tools/rosetta/lib/internal/service/online.go Outdated Show resolved Hide resolved
tools/rosetta/lib/logger/logger.go
var LoggerKey struct{}

func NewLogger() *zerolog.Logger {
output := zerolog.ConsoleWriter{Out: os.Stdout, TimeFormat: time.Kitchen}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍣

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2022

[Cosmos SDK - SimApp] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2022

[Cosmos SDK - Rosetta] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2022

[Cosmos SDK] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@julienrbrt julienrbrt merged commit ed5124f into main Dec 7, 2022
@julienrbrt julienrbrt deleted the julien/rosetta branch December 7, 2022 00:19
@julienrbrt julienrbrt mentioned this pull request Dec 7, 2022
Merged
19 tasks
@julienrbrt julienrbrt mentioned this pull request Jan 30, 2023
Closed
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@julienrbrt
feat: standalone rosetta command (cosmos#14118)
9f2e893
@coderabbitai coderabbitai bot mentioned this pull request Apr 23, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

Assignees

@facundomedica facundomedica

@tac0turtle tac0turtle

Labels
C:Rosetta Issues and PR related to Rosetta Type: Build Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rosetta: create a way to install rosetta separate from the node.
4 participants
@julienrbrt @tac0turtle @alexanderbez @facundomedica