types/int: Switch Int, Uint to use pointers internally #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the amount of pointer refs & derefs.
cwgoes
reviewed
Jun 26, 2018
types/int.go
Outdated
| @@ -43,6 +47,13 @@ func marshalAmino(i *big.Int) (string, error) { | |||
|
|
|||
| // UnmarshalAmino for custom decoding scheme | |||
| func unmarshalAmino(i *big.Int, text string) (err error) { | |||
| if i == nil { | |||
There was a problem hiding this comment.
Do we want to merge this code?
cwgoes
reviewed
Jun 26, 2018
types/int.go
Outdated
| @@ -53,32 +64,39 @@ func marshalJSON(i *big.Int) ([]byte, error) { | |||
|
|
|||
| // UnmarshalJSON for custom decoding scheme | |||
| func unmarshalJSON(i *big.Int, bz []byte) error { | |||
| if i == nil { | |||
There was a problem hiding this comment.
Do we want to merge this code?
There was a problem hiding this comment.
Oh woops, glad you caught that
Codecov Report
@@ Coverage Diff @@
## develop #1388 +/- ##
==========================================
- Coverage 64.66% 64.46% -0.2%
==========================================
Files 112 112
Lines 6282 6303 +21
==========================================
+ Hits 4062 4063 +1
- Misses 1997 2015 +18
- Partials 223 225 +2 |
|
Just realized big.Rat isn't stored via pointer. Should I change that in this PR too? |
Sure. |
|
Done! |
adrianbrink
pushed a commit
that referenced
this pull request
Jul 2, 2018
* types/int: Switch Int, Uint to use pointers internally This reduces the amount of pointer refs & derefs. * Fix nil pointers on unmarshalling amino * Fix elusive bug in marshalling with unitialized big int * Remove debug code * Switch big.rat to use pointers internally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the amount of pointer refs & derefs.
I forgot to update the changelog for gaiad unsafe reset all, so I did that here as well.