-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: populate oldest_block_identifier and wrap jsonrpc errors #13832
fix: populate oldest_block_identifier and wrap jsonrpc errors #13832
Conversation
// fromTendermintToRosettaError converts a tendermint jsonrpc error to rosetta error | ||
func fromTendermintToRosettaError(err *tmtypes.RPCError) *Error { | ||
return &Error{rosErr: &types.Error{ | ||
Code: int32(err.Code), |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13832 +/- ##
==========================================
- Coverage 56.62% 56.27% -0.36%
==========================================
Files 647 650 +3
Lines 56100 56231 +131
==========================================
- Hits 31766 31642 -124
- Misses 21772 22024 +252
- Partials 2562 2565 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we get a changelog for this change.
Because Rosetta have its own go mod the changelog is at tools/rosetta/CHANGELOG.md. Could you update this one instead :) |
My bad. Already updated :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK! If you rebase, we can merge.
52b7bc7
to
991fd4a
Compare
991fd4a
to
3a8349f
Compare
@JulianToledano Shall we tag a |
more fixes coming probably next week |
Description
Closes:
#13830
#13827
/network/status
response:oldest_block_identifier
withEarliestBlockHeight
from rpc syncInfogenesis_block_identifier
with block of height 1InitialHeight
from genesis docoldest_block_identifier
github.com/tendermint/tendermint/rpc/jsonrpc/types
errors to rosetta errorsAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change