feat: Add tx encode and decode endpoints

[likhita-809]

Description

ref: #13085
ref: #10856

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov]

Codecov Report

Merging #13789 (53da8b1) into main (ec27c53) will increase coverage by 0.18%.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13789      +/-   ##
==========================================
+ Coverage   56.46%   56.64%   +0.18%     
==========================================
  Files         648      647       -1     
  Lines       56221    55289     -932     
==========================================
- Hits        31747    31321     -426     
+ Misses      21909    21414     -495     
+ Partials     2565     2554      -11     

Impacted Files	Coverage Δ
x/auth/tx/service.go	0.00% <0.00%> (ø)
x/distribution/simulation/operations.go	80.64% <0.00%> (-9.68%)	⬇️
simapp/upgrades.go
simapp/genesis.go
simapp/genesis_account.go
simapp/simd/cmd/genaccounts.go
simapp/app.go
simapp/state.go
simapp/simd/cmd/testnet.go
simapp/test_helpers.go
... and 12 more

[tac0turtle]

We should document this only works with proto encoded txs, secondly is there a way we can add an amino way of encoding txs to the rest api? It could be something we attach to 1317 like before. Then we would support both tax types.

cc @ValarDragon for visibility on this

[alexanderbez]

Great work @likhita-809. We need a changelog here as well.

[tac0turtle]

Before the merge could we add amino encoding. this would help users quite a lot

[amaury1093]

@tac0turtle amino in which direction? We cannot convert an Amino-encoded Tx into a proto Tx. We can convert a proto Tx to an amino-encoded Tx though. But is there a use case for the latter?

[amaury1093]

LGTM overall, I'm proposing an optimized way of doing encoding below

[amaury1093]

LGTM

[tac0turtle]

@tac0turtle amino in which direction? We cannot convert an Amino-encoded Tx into a proto Tx. We can convert a proto Tx to an amino-encoded Tx though. But is there a use case for the latter?

can we expose an endpoint allowing users to encode amino txs? I would think the use case is multisigs and any sort of ledger support

[amaury1093]

Just to be clear, you are asking to encode a proto Tx to amino Tx? This won't help any of the 2 use cases you mentioned:

ledger support

What ledger receives is a StdSignDoc. We can add an endpoint from unsigned proto Tx to StdSignDoc if that's useful, but it's not an amino-encoded tx.

multisig

Amino is used in multisigs to get the address. Not sure how a proto Tx to amino Tx encoder would help.

[tac0turtle]

what Im thinking is not related to proto tx. if someone would like to encode a amino tx they cant use this endpoint, so can we offer an endpoint to help them?

[amaury1093]

I'm still not understanding what you mean by "encode a amino tx". Maybe you can write the request and response types of the endpoint?

Also, how about we merge this PR, and discuss this additional endpoint in an issue?

[tac0turtle]

#10856 (comment)

This issue asked about adding an endpoint to encode all versions, proto and amino. Right now this is only supporting proto.

[amaury1093]

Ah ok, so it's an endpoint that encodes/decodes amino JSON <-> amino binary?

[alexanderbez]

Ah ok, so it's an endpoint that encodes/decodes amino JSON <-> amino binary?

Do we want to block this PR on that or create a new separate PR for those endpoints?

[tac0turtle]

lets create a new pr for that, but lets leave the same issue opened

[amaury1093]

SGTM. @likhita-809 are you okay to work on that new PR too?

[likhita-809]

SGTM. @likhita-809 are you okay to work on that new PR too?

yeah, sure