feat!: integrate autocli and reflection services with simapp legacy #13746
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13746 +/- ##
==========================================
- Coverage 56.66% 56.53% -0.13%
==========================================
Files 636 646 +10
Lines 54552 55903 +1351
==========================================
+ Hits 30911 31607 +696
- Misses 21134 21749 +615
- Partials 2507 2547 +40
|
| @@ -430,6 +433,14 @@ func NewSimApp( | |||
| app.configurator = module.NewConfigurator(app.appCodec, app.MsgServiceRouter(), app.GRPCQueryRouter()) | |||
| app.ModuleManager.RegisterServices(app.configurator) | |||
|
|
|||
| autocliv1.RegisterQueryServer(app.GRPCQueryRouter(), runtimeservices.NewAutoCLIQueryService(app.ModuleManager.Modules)) | |||
| @@ -430,6 +433,14 @@ func NewSimApp( | |||
| app.configurator = module.NewConfigurator(app.appCodec, app.MsgServiceRouter(), app.GRPCQueryRouter()) | |||
| app.ModuleManager.RegisterServices(app.configurator) | |||
|
|
|||
| autocliv1.RegisterQueryServer(app.GRPCQueryRouter(), runtimeservices.NewAutoCLIQueryService(app.ModuleManager.Modules)) | |||
|
|
|||
| reflectionSvc, err := runtimeservices.NewReflectionService() | |||
There was a problem hiding this comment.
Let's maybe add a quick note in upgrading.md for v0.47
There was a problem hiding this comment.
cc @ilgooz for visibility on this feature
| @@ -14,7 +15,7 @@ type AutoCLIQueryService struct { | |||
| moduleOptions map[string]*autocliv1.ModuleOptions | |||
| } | |||
|
|
|||
| func NewAutoCLIQueryService(appModules map[string]appmodule.AppModule) *AutoCLIQueryService { | |||
| func NewAutoCLIQueryService(appModules map[string]module.AppModule) *AutoCLIQueryService { | |||
There was a problem hiding this comment.
not related to this line specifically, but why didn't we make runtime a go.mod?
There was a problem hiding this comment.
We can't yet because all modules depend on runtime and runtime depends on baseapp and types.
There was a problem hiding this comment.
Why the downvote @julienrbrt ?
There was a problem hiding this comment.
I understand the split for tools, or things that needs to iterate faster than the SDK.
If we extract runtime, this means different modules could have different version of runtime.
This adds a variable of what a module must be compatible to. It makes for sense if you have modules compatible with SDK versions only and not additionally runtime. These (runtime + sdk types) seems so tight to each another anyway that I, personally, don't understand the added value.
Unless I am missing something.
…osmos#13746) * feat!: integrate autocli and reflection services with simapp legacy * rename alias * update UPGRADING.md Co-authored-by: Julien Robert <[email protected]>
Description
Follow-up to #13281 (comment)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change