-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: staking param link fix #13745
docs: staking param link fix #13745
Conversation
@@ -83,7 +83,7 @@ UnbondingID stores the ID of the latest unbonding operation. It enables to creat | |||
|
|||
* UnbondingID: `0x37 -> uint64` | |||
|
|||
## Params | |||
## Parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the relation with the PR title and this fix 😅
If we modify that, can you update the ToC link too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the toc was pointing to parameters, but the title was params so the link wasn't working. this fixed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wdym, the toc was pointing to params: https://github.com/cosmos/cosmos-sdk/pull/13745/files/30648a50f82b41932fcdf67121e2223d08bcdff6#diff-8cae4b5d28bad715411b21d035d60df66c05405a5b166c24b1eb5000998e16d6R26, now it is broken -> https://docs.cosmos.network/main/modules/staking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting this in another doc PR then: a428f39
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't revert it works now
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change