Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add Textual SignModeHandler #13734

Closed
wants to merge 98 commits into from
Closed

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Nov 2, 2022

Description

Closes: #13700
Closes: #13747

This PR adds:

  • a new sign mode handler for Textual
  • all client-side and ledger-side infrastructure to make it work

Depends on:


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

x/auth/tx/textual.go Outdated Show resolved Hide resolved
tx/textual/valuerenderer/valuerenderer.go Outdated Show resolved Hide resolved
tx/textual/valuerenderer/valuerenderer.go Outdated Show resolved Hide resolved
x/auth/tx/textual.go Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the stale label Jan 10, 2023
@github-actions github-actions bot added the C:CLI label Jan 11, 2023
Base automatically changed from am/13579-textual-tx to main January 11, 2023 12:25
@amaury1093
Copy link
Contributor Author

amaury1093 commented Jan 17, 2023

This was mainly an exploration PR to make the e2e flow work. I'll close this PR, and divide it into 2 separate ones:

  1. one solely for add the SignModeHandler: feat: Add Textual SignModeHandler #14650
  2. another one for client-side infra: CLI flags, keyring, ledger support, and tests (tracked by Allow client-side signing with SIGN_MODE_TEXTUAL  #13747(

@amaury1093 amaury1093 closed this Jan 17, 2023
@amaury1093 amaury1093 deleted the am/textual-wip-handler branch January 17, 2023 12:44
@amaury1093 amaury1093 mentioned this pull request Jan 17, 2023
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow client-side signing with SIGN_MODE_TEXTUAL Add Textual SignModeHandler
2 participants