-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: deterministic tests and add gas tests #13539
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
reviewed
Oct 13, 2022
atheeshp
changed the title
refactor: x/auth deterministic tests
refactor: deterministic tests
Oct 14, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13539 +/- ##
========================================
Coverage 54.69% 54.69%
========================================
Files 647 645 -2
Lines 55915 55745 -170
========================================
- Hits 30582 30491 -91
+ Misses 22840 22764 -76
+ Partials 2493 2490 -3
|
amaury1093
reviewed
Oct 19, 2022
amaury1093
changed the title
refactor: deterministic tests
refactor: deterministic tests and add gas tests
Oct 19, 2022
alexanderbez
approved these changes
Oct 19, 2022
JeancarloBarrios
approved these changes
Oct 20, 2022
amaury1093
reviewed
Oct 24, 2022
amaury1093
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this looks cleaner. @atheeshp feel free to merge once the last nits are addressed
…smos-sdk into ap/auth-deterministic-refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
follow-up: #13329
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change