Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve and clarify API around AccountAddressById #13460

Merged
merged 9 commits into from
Oct 6, 2022
+166 −110
Merged

refactor: Improve and clarify API around AccountAddressById #13460

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c864bc7
Revert "chore: change id to use uint64 in `AccountAddressByID` (#13411)"
amaury1093 Oct 6, 2022
f390a86
Add since
amaury1093 Oct 6, 2022
1e3ab69
Update CLI command
amaury1093 Oct 6, 2022
169eee3
make proto-gen
amaury1093 Oct 6, 2022
32002d0
id->accNum
amaury1093 Oct 6, 2022
4e659ce
No API breaking changes
amaury1093 Oct 6, 2022
de15237
improve err msg
amaury1093 Oct 6, 2022
3a5d77a
Update CHANGELOG.md
amaury1093 Oct 6, 2022
ed6a946
Update CHANGELOG.md
amaury1093 Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
id->accNum
@amaury1093
amaury1093 committed Oct 6, 2022
commit 32002d0c3c194e13fc64892e6caaca53bb08f57d
2 changes: 1 addition & 1 deletion proto/cosmos/auth/v1beta1/query.proto
View file
Original file line number Diff line number Diff line change
@@ -30,7 +30,7 @@ service Query {
option (google.api.http).get = "/cosmos/auth/v1beta1/accounts/{address}";
}

// AccountAddressByID returns account address based on account id
// AccountAddressByID returns account address based on account number.
//
// Since: cosmos-sdk 0.46.2
rpc AccountAddressByID(QueryAccountAddressByIDRequest) returns (QueryAccountAddressByIDResponse) {