Reverted ChangePubKey #1340
Merged
Reverted ChangePubKey #1340
+2
−195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1340 +/- ##
===========================================
- Coverage 65.5% 64.77% -0.73%
===========================================
Files 114 112 -2
Lines 6305 6271 -34
===========================================
- Hits 4130 4062 -68
- Misses 1949 1985 +36
+ Partials 226 224 -2 |
cwgoes
reviewed
Jun 22, 2018
x/auth/mapper.go
Outdated
| @@ -101,7 +101,7 @@ func (am AccountMapper) GetPubKey(ctx sdk.Context, addr sdk.Address) (crypto.Pub | |||
| } | |||
|
|
|||
| // Sets the PubKey of the account at address | |||
| func (am AccountMapper) SetPubKey(ctx sdk.Context, addr sdk.Address, newPubKey crypto.PubKey) sdk.Error { | |||
| func (am AccountMapper) setPubKey(ctx sdk.Context, addr sdk.Address, newPubKey crypto.PubKey) sdk.Error { | |||
There was a problem hiding this comment.
Can we delete this? It's not used anywhere as far as I can tell.
adrianbrink
pushed a commit
that referenced
this pull request
Jul 2, 2018
* removed msgChangePubKey * changelog * removed setPubKey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1250