-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect versions of imported protos in Makefile #12701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faddat
changed the title
bug: fix versions of imported protos in Makefile
fix: fix versions of imported protos in Makefile
Jul 23, 2022
github-actions
bot
added
C:x/distribution
distribution module related
C:x/params
C:x/upgrade
labels
Jul 23, 2022
faddat
changed the title
fix: fix versions of imported protos in Makefile
fix: incorrect versions of imported protos in Makefile
Jul 23, 2022
alexanderbez
approved these changes
Jul 23, 2022
Can we do the same thing for |
julienrbrt
approved these changes
Jul 23, 2022
julienrbrt
reviewed
Jul 23, 2022
tac0turtle
reviewed
Jul 24, 2022
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Marko <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Sure, can do the same thing for main :) |
tac0turtle
approved these changes
Jul 25, 2022
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This modifies the Makefile to ensure that we are fetching the correct version of imported .proto files.
Tendermint and ics23 were wrong.
It also does a nice old-fashioned "make proto-gen" for good measure.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change