Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct confusing comments in ante.IncrementSequenceDecorator #12604

Merged
merged 1 commit into from
Jul 18, 2022
Merged

docs: correct confusing comments in ante.IncrementSequenceDecorator #12604

merged 1 commit into from
Jul 18, 2022

Conversation

shaneing
Copy link
Contributor

Description

// there is no need to execute IncrementSequenceDecorator on RecheckTX since

There is a wrong comment.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@shaneing shaneing requested a review from a team as a code owner July 17, 2022 13:19
@alexanderbez alexanderbez added the backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release label Jul 18, 2022
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #12604 (74a31f5) into main (0a3c597) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12604      +/-   ##
==========================================
+ Coverage   65.20%   65.22%   +0.02%     
==========================================
  Files         693      693              
  Lines       71840    71840              
==========================================
+ Hits        46843    46861      +18     
+ Misses      22367    22348      -19     
- Partials     2630     2631       +1     
Impacted Files Coverage Δ
x/auth/ante/sigverify.go 66.99% <ø> (ø)
x/distribution/simulation/operations.go 90.42% <0.00%> (+9.57%) ⬆️

@alexanderbez alexanderbez merged commit 6a08830 into cosmos:main Jul 18, 2022
mergify bot pushed a commit that referenced this pull request Jul 18, 2022
alexanderbez pushed a commit that referenced this pull request Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants