-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [Interchain Security] Add equality to validator.IsMature #12537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is OK and true since it's within the context of the current executing block, but I'm not 100% certain as x/staking has the assumption of H+1 execution due to the current Tendermint model.
I see simulations failing so this makes me slightly even more worried. Regardless, let's add a changelog and then investigate sim failures.
@alexanderbez this PR shouldn't break the tests since the change only affects code that is called when Interchain Security (IS) is enabled, and I'm quite sure that there are no checks for that :) The function |
Closes cosmos/interchain-security#111 (see cosmos/interchain-security#111 (comment) for details).