Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: (x/authz) add helpers AppendBytes, ParseByteSlice #11713

Merged
merged 7 commits into from
Apr 21, 2022

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Apr 21, 2022

Description

Closes: #11578


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #11713 (8e7751f) into master (79031f2) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11713      +/-   ##
==========================================
+ Coverage   65.91%   65.94%   +0.02%     
==========================================
  Files         667      667              
  Lines       70460    70466       +6     
==========================================
+ Hits        46441    46466      +25     
+ Misses      21324    21304      -20     
- Partials     2695     2696       +1     
Impacted Files Coverage Δ
types/utils.go 76.05% <100.00%> (+9.38%) ⬆️
x/authz/keeper/keys.go 93.61% <100.00%> (-1.47%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️
x/distribution/simulation/operations.go 90.27% <0.00%> (+9.72%) ⬆️

@atheeshp atheeshp changed the title chore: add helpers AppendBytes, ParseByteSlice chore: (x/authz) add helpers AppendBytes, ParseByteSlice Apr 21, 2022
@atheeshp atheeshp marked this pull request as ready for review April 21, 2022 12:59
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

types/utils.go Outdated Show resolved Hide resolved
types/utils.go Outdated Show resolved Hide resolved
@atheeshp atheeshp requested a review from alexanderbez April 21, 2022 14:08
@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 21, 2022
@alexanderbez alexanderbez merged commit d4dd444 into master Apr 21, 2022
@alexanderbez alexanderbez deleted the ap/append_parse_bytes branch April 21, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/authz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/authz suggestion for refactoring of creation/parsing of GrantKey and GrantQueueKey
4 participants