Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin go version Dockerfiles #11711

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 20, 2022

Description

closes: #11709
ref: #11663

Pin against Go versions in Dockerfiles

cc @faddat


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:Rosetta Issues and PR related to Rosetta label Apr 20, 2022
@alexanderbez alexanderbez marked this pull request as ready for review April 20, 2022 18:26
@alexanderbez alexanderbez requested a review from aaronc as a code owner April 20, 2022 18:26
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexanderbez alexanderbez merged commit 2f6a3e6 into master Apr 20, 2022
@alexanderbez alexanderbez deleted the bez/11709-dockerfile-go-pin branch April 20, 2022 18:33
@faddat
Copy link
Contributor

faddat commented Apr 20, 2022

#11688

@alexanderbez FYI, if we definable don't want versions to "roll" then we probably shouldn't use Arch-- that's kind of its precept.

@alexanderbez
Copy link
Contributor Author

@faddat I'm open to your suggestions. I just think it's

  1. Best to pin against explicit dependency versions
  2. This PR actually fixed the localnet stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Rosetta Issues and PR related to Rosetta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

liveness test failure
3 participants