Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(orm)!: move orm.proto to v1 #11383

Merged
merged 5 commits into from
Mar 26, 2022
Merged

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Mar 15, 2022

Description

Ref #11381

  • move orm.proto from v1alpha1 -> v1
  • change documentation for bytes keys to use a var uint32

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #11383 (9746886) into master (20735e7) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 9746886 differs from pull request most recent head 64bbb90. Consider uploading reports for the commit 64bbb90 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11383      +/-   ##
==========================================
+ Coverage   65.86%   65.91%   +0.05%     
==========================================
  Files         675      709      +34     
  Lines       69773    72605    +2832     
==========================================
+ Hits        45955    47859    +1904     
- Misses      21118    21780     +662     
- Partials     2700     2966     +266     
Impacted Files Coverage Δ
testutil/network/network.go 62.22% <0.00%> (-0.19%) ⬇️
server/config/config.go 38.63% <0.00%> (-0.17%) ⬇️
types/utils.go 66.66% <0.00%> (ø)
server/mock/app.go 81.72% <0.00%> (ø)
server/config/toml.go 66.66% <0.00%> (ø)
store/v2alpha1/multi/migration.go
orm/internal/stablejson/encode.go 67.60% <0.00%> (ø)
orm/model/ormtable/paginate.go 83.92% <0.00%> (ø)
orm/encoding/ormfield/uint32.go 73.77% <0.00%> (ø)
orm/encoding/ormfield/string.go 86.04% <0.00%> (ø)
... and 32 more

@robert-zaremba robert-zaremba added A:automerge Automatically merge PR once all prerequisites pass. C:orm labels Mar 17, 2022
@github-actions github-actions bot removed the C:orm label Mar 25, 2022
@mergify mergify bot merged commit 462d017 into master Mar 26, 2022
@mergify mergify bot deleted the aaronc/11381-orm-proto-v1 branch March 26, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants