-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(orm)!: move orm.proto to v1 #11383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronc
requested review from
robert-zaremba,
technicallyty,
fdymylja and
tac0turtle
March 15, 2022 20:40
tac0turtle
approved these changes
Mar 15, 2022
Codecov Report
@@ Coverage Diff @@
## master #11383 +/- ##
==========================================
+ Coverage 65.86% 65.91% +0.05%
==========================================
Files 675 709 +34
Lines 69773 72605 +2832
==========================================
+ Hits 45955 47859 +1904
- Misses 21118 21780 +662
- Partials 2700 2966 +266
|
atheeshp
approved these changes
Mar 17, 2022
likhita-809
approved these changes
Mar 17, 2022
robert-zaremba
approved these changes
Mar 17, 2022
robert-zaremba
added
A:automerge
Automatically merge PR once all prerequisites pass.
C:orm
labels
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref #11381
orm.proto
fromv1alpha1
->v1
bytes
keys to use a var uint32Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change