Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add metadata field to proposal #10989

Merged
merged 9 commits into from
Jan 25, 2022
Merged

feat: Add metadata field to proposal #10989

merged 9 commits into from
Jan 25, 2022

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Jan 20, 2022

Description

Closes: #10490


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@@ -48,6 +51,7 @@ type Keeper struct {
func NewKeeper(
cdc codec.BinaryCodec, key storetypes.StoreKey, paramSpace types.ParamSubspace,
authKeeper types.AccountKeeper, bankKeeper types.BankKeeper, sk types.StakingKeeper, rtr v1beta1.Router,
maxMetadataLen uint64,
Copy link
Contributor Author

@amaury1093 amaury1093 Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, given the number of args, I'm inclined to actually put one single arg to this function, as a struct. It'll be future-proof, if we ever add even more args in the future.

@amaury1093 amaury1093 marked this pull request as ready for review January 21, 2022 17:43
@github-actions github-actions bot added the C:CLI label Jan 21, 2022
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #10989 (c9e189c) into master (6ea2049) will decrease coverage by 0.08%.
The diff coverage is 69.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10989      +/-   ##
==========================================
- Coverage   66.03%   65.95%   -0.09%     
==========================================
  Files         690      647      -43     
  Lines       69558    65873    -3685     
==========================================
- Hits        45933    43445    -2488     
+ Misses      20830    19940     -890     
+ Partials     2795     2488     -307     
Impacted Files Coverage Δ
x/gov/keeper/msg_server.go 6.57% <0.00%> (-0.04%) ⬇️
x/gov/types/v1beta2/proposal.go 15.62% <0.00%> (-0.25%) ⬇️
x/gov/client/utils/query.go 19.28% <25.00%> (ø)
x/gov/types/v1beta2/msgs.go 63.69% <55.55%> (+18.62%) ⬆️
simapp/app.go 82.44% <100.00%> (+0.05%) ⬆️
x/auth/tx/service.go 71.69% <100.00%> (+0.41%) ⬆️
x/bank/keeper/send.go 83.07% <100.00%> (+0.08%) ⬆️
x/gov/keeper/keeper.go 78.37% <100.00%> (+0.29%) ⬆️
x/gov/keeper/proposal.go 77.84% <100.00%> (+0.26%) ⬆️
... and 48 more

proto/cosmos/gov/v1beta2/gov.proto Outdated Show resolved Hide resolved
proto/cosmos/gov/v1beta2/tx.proto Outdated Show resolved Hide resolved
x/gov/types/v1beta2/msgs.go Show resolved Hide resolved
x/gov/keeper/proposal.go Show resolved Hide resolved
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jan 25, 2022
@mergify mergify bot merged commit 95e65fe into master Jan 25, 2022
@mergify mergify bot deleted the am/10490-metadata branch January 25, 2022 10:52
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
## Description

Closes: cosmos#10490 




---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:Simulations C:x/auth C:x/gov
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gov: add metadata field to proposal
3 participants