Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 0.44.4 release notes #10613

Merged
merged 5 commits into from
Nov 25, 2021
Merged

chore: 0.44.4 release notes #10613

merged 5 commits into from
Nov 25, 2021

Conversation

robert-zaremba
Copy link
Collaborator

Description

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba changed the title Robert/0.44.4 release notes chore: 0.44.4 release notes Nov 25, 2021
@github-actions github-actions bot added C:CLI C:Cosmovisor Issues and PR related to Cosmovisor C:Keys Keybase, KMS and HSMs C:Rosetta Issues and PR related to Rosetta C:Simulations C:Store C:x/auth C:x/authz C:x/bank C:x/capability C:x/crisis C:x/distribution distribution module related C:x/evidence C:x/feegrant C:x/genutil genutil module issues C:x/gov C:x/mint C:x/slashing C:x/staking C:x/upgrade T: ADR An issue or PR relating to an architectural decision record Type: Build T: CI labels Nov 25, 2021
@robert-zaremba robert-zaremba added A:automerge Automatically merge PR once all prerequisites pass. and removed C:x/distribution distribution module related C:x/mint C:Simulations Type: Build T: ADR An issue or PR relating to an architectural decision record C:x/crisis C:x/evidence C:x/upgrade C:x/feegrant C:x/capability C:x/genutil genutil module issues C:x/authz C:Cosmovisor Issues and PR related to Cosmovisor C:Rosetta Issues and PR related to Rosetta labels Nov 25, 2021
amaury1093
amaury1093 reviewed Nov 25, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
RELEASE_NOTES.md Outdated Show resolved Hide resolved
RELEASE_NOTES.md Outdated

This release notably also:
Other bug fixes:
+ query account balance by ibc denom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a client-breaking change for HTTP clients. We should document that better:

- /bank/v1beta1/balances/{address}/{ibc_denom}
+ /bank/v1beta1/balances/{address}/by_denom?denom={ibc_denom}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've added more details. I'm not sure if we should link PRs here - these are in the changelog.

@github-actions github-actions bot removed C:x/bank C:x/auth C:Keys Keybase, KMS and HSMs labels Nov 25, 2021
tac0turtle
tac0turtle approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm pending comments being resolved

@robert-zaremba @amaury1093
Update CHANGELOG.md
4d08339 
Co-authored-by: Amaury <[email protected]>
amaury1093
amaury1093 approved these changes Nov 25, 2021
View reviewed changes
RELEASE_NOTES.md Outdated Show resolved Hide resolved
@robert-zaremba robert-zaremba merged commit 59d7dc4 into release/v0.44.x Nov 25, 2021
@robert-zaremba robert-zaremba deleted the robert/0.44.4-release-notes branch November 25, 2021 17:25
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@robert-zaremba @amaury1093 @JeancarloBarrios
chore: 0.44.4 release notes (cosmos#10613)
53bff9a 
* 0.44.4 Release Notes

* Update RELEASE_NOTES.md

Co-authored-by: Amaury <[email protected]>

* review updates

* Update CHANGELOG.md

Co-authored-by: Amaury <[email protected]>

* Update RELEASE_NOTES.md

Co-authored-by: Amaury <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@alessio alessio Awaiting requested review from alessio

@ryanchristo ryanchristo Awaiting requested review from ryanchristo

@technicallyty technicallyty Awaiting requested review from technicallyty

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Store
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robert-zaremba @amaury1093 @tac0turtle