Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check error for RegisterQueryHandlerClient in all modules RegisterGRPCGatewayRoutes #10439

Merged
merged 7 commits into from
Oct 28, 2021

Conversation

likhita-809
Copy link
Contributor

@likhita-809 likhita-809 commented Oct 26, 2021

Description

Closes: #10437

Checks the error for RegisterQueryHandlerClient in all modules RegisterGRPCGatewayRoutes


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

…khita/check-error-for-RegisterQueryHandlerClient
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #10439 (00c1325) into master (1d1fcc9) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 00c1325 differs from pull request most recent head 9b54227. Consider uploading reports for the commit 9b54227 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10439      +/-   ##
==========================================
- Coverage   64.24%   64.20%   -0.05%     
==========================================
  Files         581      581              
  Lines       55199    55206       +7     
==========================================
- Hits        35465    35447      -18     
- Misses      17715    17741      +26     
+ Partials     2019     2018       -1     
Impacted Files Coverage Δ
x/bank/module.go 53.42% <0.00%> (-0.75%) ⬇️
x/distribution/module.go 59.15% <0.00%> (-0.85%) ⬇️
x/evidence/module.go 48.61% <0.00%> (-0.69%) ⬇️
x/mint/module.go 52.54% <0.00%> (ø)
x/params/module.go 50.00% <0.00%> (-1.12%) ⬇️
x/slashing/module.go 57.74% <0.00%> (-0.83%) ⬇️
x/staking/module.go 63.01% <0.00%> (-0.88%) ⬇️
x/upgrade/module.go 61.90% <0.00%> (-1.51%) ⬇️
x/distribution/simulation/operations.go 80.54% <0.00%> (-9.73%) ⬇️

…khita/check-error-for-RegisterQueryHandlerClient
…khita/check-error-for-RegisterQueryHandlerClient
@likhita-809 likhita-809 marked this pull request as ready for review October 28, 2021 05:08
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, let's also add a changelog entry

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 28, 2021
@mergify mergify bot merged commit b5ca8e0 into master Oct 28, 2021
@mergify mergify bot deleted the likhita/check-error-for-RegisterQueryHandlerClient branch October 28, 2021 11:01
@ValarDragon
Copy link
Contributor

Our errorcheck linter is very thankful for this 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check error for RegisterQueryHandlerClient in all modules RegisterGRPCGatewayRoutes
5 participants