Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: db/dbtest/util #10403

Merged
merged 1 commit into from
Oct 19, 2021
Merged

fix: db/dbtest/util #10403

merged 1 commit into from
Oct 19, 2021

Conversation

roysc
Copy link
Contributor

@roysc roysc commented Oct 19, 2021

Description

Closes: #XXXX

See https://dashboard.github.orijtech.com/benchmark/c29ef717d40744458619a51d565e7471


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #10403 (305075c) into master (85eed1f) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10403      +/-   ##
==========================================
+ Coverage   64.38%   64.42%   +0.03%     
==========================================
  Files         573      573              
  Lines       54625    54625              
==========================================
+ Hits        35172    35191      +19     
+ Misses      17457    17437      -20     
- Partials     1996     1997       +1     
Impacted Files Coverage Δ
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️
x/distribution/simulation/operations.go 90.27% <0.00%> (+9.72%) ⬆️

@tac0turtle tac0turtle merged commit 2cbdf8f into cosmos:master Oct 19, 2021
@roysc roysc deleted the fix-dbtest-util branch October 19, 2021 14:52
@odeke-em
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants