Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(authz) Keeper function to iterate all grant of granter #9966

Closed
4 tasks
taobun opened this issue Aug 18, 2021 · 3 comments · Fixed by #10326
Closed
4 tasks

(authz) Keeper function to iterate all grant of granter #9966

taobun opened this issue Aug 18, 2021 · 3 comments · Fixed by #10326
Assignees

Comments

@taobun
Copy link

taobun commented Aug 18, 2021

Summary

Problem Definition

We are looking to use authz module to authorize accounts to send msg for a validator. Logic to grant auth to account works well, but we cannot query all grants of the validator (list of all accounts of validator).

Proposal

I propose a new function in authz keeper

func (k Keeper) IterateGrantsOfGranter(ctx sdk.Context, granter sdk.AccAddress,
	handler func(granterAddr sdk.AccAddress, granteeAddr sdk.AccAddress, grant authz.Grant) bool) {
    store := ctx.KVStore(k.storeKey)
    iter := sdk.KVStorePrefixIterator(store, GrantKey + granter)
    ....
}

And we can create expect_keeper of this to use in our module to get all grants by a validator. If it possible to specific msgType , this should be good.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@clevinson
Copy link
Contributor

I think the idea would be to use the authz.keeper.Grants query method (it's also defined in the gRPC querier if you'd rather go through that route).

@taobun
Copy link
Author

taobun commented Aug 23, 2021

What I want is an endpoint to receive a granter address and return all grantees. But authz.keeper.Grants query that need granter and grantee to find all grants from this tuple. In keeper I only find IterateGrants function, but it need to iterate all grants in store, so I want we can add granter as prefix of iterator to list all value that has prefix of granter.

@taobun
Copy link
Author

taobun commented Sep 1, 2021

Any update on this @clevinson ?

@aleem1314 aleem1314 self-assigned this Oct 6, 2021
@mergify mergify bot closed this as completed in #10326 Oct 11, 2021
mergify bot pushed a commit that referenced this issue Oct 11, 2021
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

Closes: #9966 

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants