Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show fractionals as decimals in the UI #1353

Closed
adrianbrink opened this issue Jun 24, 2018 · 0 comments
Closed

Show fractionals as decimals in the UI #1353

adrianbrink opened this issue Jun 24, 2018 · 0 comments

Comments

@adrianbrink
Copy link
Contributor

It would be nice if gaiacli would round the output of fractionals by default.

Instead of 11869500/11809 it would be more user friendly if it showed 1,005.12
7768 pushed a commit to 7768/cosmos-sdk that referenced this issue Jun 24, 2018
CLI: Show fractionals as decimals
05bc706 
🐛 Fix cosmos#1353

before:
```
Shares: Status Bonded,  Amount: -6508168128760126341/-3308135364330552608
Delegator Shares: -6508168128760126341/-3308135364330552608
```
after:
```
Shares: Status Bonded,  Amount: 2.0000000000
Delegator Shares: 2.0000000000
```
@7768 7768 mentioned this issue Jun 24, 2018
Merged
6 tasks
7768 pushed a commit to 7768/cosmos-sdk that referenced this issue Jun 26, 2018
CLI: Show fractional in human-readable format
2a46845 
� Fix cosmos#1353

before:
```
Shares: Status Bonded,  Amount: -6508168128760126341/-3308135364330552608
Delegator Shares: -6508168128760126341/-3308135364330552608
```
after:
```
Shares: Status Bonded,  Amount: 2.0000000000
Delegator Shares: 2.0000000000
```

<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺
v                               ✰  Thanks for creating a PR! ✰
v    Before smashing the submit button please review the checkboxes.
v    If a checkbox is n/a - please still include it but + a little note why
☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >  -->

* [ ] Updated all relevant documentation in docs
* [ ] Updated all code comments where relevant
* [ ] Wrote tests
* [ ] Updated CHANGELOG.md
* [ ] Updated Gaia/Examples
* [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))
cwgoes pushed a commit that referenced this issue Jun 26, 2018
@7768 @cwgoes
Merge PR 1354: CLI: Show fractional in human-readable format
4f57a76 
Fix #1353

before:
```
Shares: Status Bonded,  Amount: -6508168128760126341/-3308135364330552608
Delegator Shares: -6508168128760126341/-3308135364330552608
```
after:
```
Shares: Status Bonded,  Amount: 2.0000000000
Delegator Shares: 2.0000000000
```
adrianbrink pushed a commit that referenced this issue Jul 2, 2018
@7768
Merge PR 1354: CLI: Show fractional in human-readable format
62dc17f 
Fix #1353

before:
```
Shares: Status Bonded,  Amount: -6508168128760126341/-3308135364330552608
Delegator Shares: -6508168128760126341/-3308135364330552608
```
after:
```
Shares: Status Bonded,  Amount: 2.0000000000
Delegator Shares: 2.0000000000
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adrianbrink