Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gov: generate proto types into types/v1beta2 instead of types #10793

Closed
4 tasks
amaury1093 opened this issue Dec 16, 2021 · 0 comments · Fixed by #10852
Closed
4 tasks

Gov: generate proto types into types/v1beta2 instead of types #10793

amaury1093 opened this issue Dec 16, 2021 · 0 comments · Fixed by #10852
Assignees
@atheeshp
Labels
C: Proto Proto definition and proto release C:x/gov

Comments

@amaury1093
Copy link
Contributor

Summary

Consider generating proto files into types/v1beta2 instead of types

Problem Definition

Historically, we generated types in the types folder of each module.

For gov, we will now maintain 2 versions: v1beta1 and v1beta2. The current way we're going in #10763 is to generate:

  • v1beta1 types in types/v1beta1
  • v1beta2 types in types

The main pro is explicitness.

Proposal

Generate v1beta2 proto types into types/v1beta2 instead of types.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093 amaury1093 added C:x/gov C: Proto Proto definition and proto release labels Dec 16, 2021
@amaury1093 amaury1093 mentioned this issue Dec 16, 2021
Merged
19 tasks
@atheeshp atheeshp self-assigned this Dec 16, 2021
@atheeshp atheeshp mentioned this issue Dec 29, 2021
Merged
19 tasks
@aaronc aaronc added this to cosmos-sdk Jan 4, 2022
@aaronc aaronc moved this to In Progress in cosmos-sdk Jan 4, 2022
@mergify mergify bot closed this as completed in #10852 Jan 4, 2022
Repository owner moved this from In Progress to Done in cosmos-sdk Jan 4, 2022
mergify bot pushed a commit that referenced this issue Jan 4, 2022
@atheeshp
refactor: move gov types to v1beta2 (#10852)
bdee333 
## Description

Closes: #10793 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atheeshp atheeshp

Labels
C: Proto Proto definition and proto release C:x/gov
Projects
No open projects
cosmos-sdk
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move gov types to v1beta2 cosmos/cosmos-sdk
2 participants
@amaury1093 @atheeshp