Skip to content

Commit

Permalink
fix(sims): Use liveness matrix for val sign status in sims (#21952)
Browse files Browse the repository at this point in the history
(cherry picked from commit 0d9b416)

# Conflicts:
#	CHANGELOG.md
  • Loading branch information
alpe authored and mergify[bot] committed Sep 27, 2024
1 parent 08c2261 commit 596440e
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,18 @@ Every module contains its own CHANGELOG.md. Please refer to the module you are i

### Improvements

<<<<<<< HEAD
* (genutil) [#21701](https://github.com/cosmos/cosmos-sdk/pull/21701) Improved error messages for genesis validation.
* (runtime) [#21704](https://github.com/cosmos/cosmos-sdk/pull/21704) Move `upgradetypes.StoreLoader` to runtime and alias it in upgrade for backward compatibility.
* (sims)[#21613](https://github.com/cosmos/cosmos-sdk/pull/21613) Add sims2 framework and factory methods for simpler message factories in modules
=======
* (sims) [#21613](https://github.com/cosmos/cosmos-sdk/pull/21613) Add sims2 framework and factory methods for simpler message factories in modules

### Bug Fixes
* (sims) [#21952](https://github.com/cosmos/cosmos-sdk/pull/21952) Use liveness matrix for validator sign status in sims
* (sims) [#21906](https://github.com/cosmos/cosmos-sdk/pull/21906) Skip sims test when running dry on validators
* (cli) [#21919](https://github.com/cosmos/cosmos-sdk/pull/21919) Query address-by-acc-num by account_id instead of id.
>>>>>>> 0d9b416cb (fix(sims): Use liveness matrix for val sign status in sims (#21952))
### API Breaking Changes

Expand Down
5 changes: 4 additions & 1 deletion x/simulation/mock_cometbft.go
Original file line number Diff line number Diff line change
Expand Up @@ -151,18 +151,21 @@ func RandomRequestFinalizeBlock(
signed = false
}

var commitStatus cmtproto.BlockIDFlag
if signed {
event("begin_block", "signing", "signed")
commitStatus = cmtproto.BlockIDFlagCommit
} else {
event("begin_block", "signing", "missed")
commitStatus = cmtproto.BlockIDFlagAbsent
}

voteInfos[i] = abci.VoteInfo{
Validator: abci.Validator{
Address: SumTruncated(mVal.val.PubKeyBytes),
Power: mVal.val.Power,
},
BlockIdFlag: cmtproto.BlockIDFlagCommit,
BlockIdFlag: commitStatus,
}
}

Expand Down

0 comments on commit 596440e

Please sign in to comment.