Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cosmos.proto to this repo #17

Merged
merged 2 commits into from
Aug 26, 2021
Merged

Conversation

cyberbono3
Copy link
Contributor

Close #4

@aaronc
Copy link
Member

aaronc commented Aug 19, 2021

Let's add some doc comments please. And what about generating the go code? Do we need to use gogo proto for now?

@amaury1093
Copy link
Contributor

And what about generating the go code? Do we need to use gogo proto for now?

For Dec and Int we're already using gogo customtype.

For AddressString/Bytes, we could also gogo and do type AddressString = string (alias) in the SDK and replace everywhere relevant, so that it's not a huge API-breaking change for 0.44. And switch to type AddressString string once we're ready (e.g. 0.45)

@aaronc
Copy link
Member

aaronc commented Aug 20, 2021

Not following the connection here @AmauryM. I'm just talking about a pb.go file for cosmos.proto. Can we use golang v2 official or do we need to use gogo?

@amaury1093
Copy link
Contributor

Ah got it I misunderstood

@cyberbono3
Copy link
Contributor Author

I added fields comments.

@cyberbono3
Copy link
Contributor Author

I think this is a blocker for Cosmos Scalars PR since cosmos.proto refers to github.com/cosmos/cosmos-proto here if i am not mistaken which is not merged yet. Can we merge this in order to unblock Cosmos Scalars? cc @technicallyty @AmauryM

@technicallyty technicallyty merged commit 0c2f864 into main Aug 26, 2021
@amaury1093 amaury1093 deleted the cyberbono3/add-cosmos-proto branch September 14, 2021 10:40
mergify bot pushed a commit to cosmos/cosmos-sdk that referenced this pull request Sep 21, 2021
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

Closes: #9694

goes hand-in-hand with cosmos/cosmos-proto#17

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [x] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move cosmos.proto to this repo
4 participants