Improve DX - Stargate sign and broadcast

[DavideSegullo]

Hi, as stated in the title of the PR I would like to suggest the inclusion of a new method to sign a tx and then not have to wait for it to be inserted into a block.

Currently it is possible to do this, but by putting workarounds with ts-ignore, I think it is more appropriate to add a method directly.

Why?

In nabla, we are working on a utility to track transactions using websockets, so it is useful to get the hash of the tx right away and then pass it to the utility, as polling is limited.

[webmaster128]

This is cool, thank you for your contribution! It closes this ticket and uses the solution I suggested over there: #1316.

I just have two change requests:

• Could you rename *WithoutPolling -> *Sync to follow the naming given by the backend? Also polling is an implementation detail that can change over time.
• Can you deduplicate the code for all cases such that e.g. broadcastTx uses broadcastTxSync for the first steps of the operation (accepted by the node)?

[DavideSegullo]

This is cool, thank you for your contribution! It closes this ticket and uses the solution I suggested over there: #1316.

I just have two change requests:

• Could you rename *WithoutPolling -> *Sync to follow the naming given by the backend? Also polling is an implementation detail that can change over time.
• Can you deduplicate the code for all cases such that e.g. broadcastTx uses broadcastTxSync for the first steps of the operation (accepted by the node)?

Yes, it seems fine to me, I did some changes, is it okay now?

[webmaster128]

Diff LGTM, thanks!

Could you add one test for each new function (one describe block per function)? No need to copy all the cases we have for signAndBroadcast but at least one happy path to ensure this does not break over time.

And then we need a CHANGELOG entry in the Unreleased section for this work.

Once we have the two things, this can get shipped in 0.31.0. Thank you!

[DavideSegullo]

Ofc, I have added some tests, please tell me if they are enought!

[webmaster128]

Let's remove those delegation tests. Otherwise the staking about in some other test fails. This is not great right now as the staking balance tests depends on the MsgDelegate tests. But let's move on here and get this in.

[DavideSegullo]

Let's remove those delegation tests. Otherwise the staking about in some other test fails. This is not great right now as the staking balance tests depends on the MsgDelegate tests. But let's move on here and get this in.

Done, I approved it!

[webmaster128]

Okay it seems like only a linting issue left. Could you fix them (with yarn && yarn lint-fix in the repo root)?

[webmaster128]

Seems like I can't push here. Could you allow changes by maintaners? Then I can write a CHANGELOG entry, push here and merge to get it in the 0.31 release.

[DavideSegullo]

Seems like I can't push here. Could you allow changes by maintaners? Then I can write a CHANGELOG entry, push here and merge to get it in the 0.31 release.

Do you know how I can enable it?

Okay it seems like only a linting issue left. Could you fix them (with yarn && yarn lint-fix in the repo root)?

Done

[webmaster128]

Thanks, see here: bisq-network/style#4

[DavideSegullo]

Thanks, see here: bisq-network/style#4

I tried it, but I don't see "Allow edits from maintainers" button

[DavideSegullo]

Well, I found out that the problem is related to cross-org PRs: https://github.com/orgs/community/discussions/5634

I'll try to give you permissions on that repo.

Update: I gave you the maintainer permissions in the repo

[webmaster128]

Thanks a lot. Will be shipped as part of 0.31