#240 - Make reducers pure by passing date as an argument. #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,6 +41,7 @@ describe('Reducers::FuelSavings', () => { | |||
| } | |||
| }; | |||
| }; | |||
| const dateModified = dateHelper.getFormattedDateTime(new Date()); | |||
There was a problem hiding this comment.
Passing new Date() is unnecessary here since it mirrors the default param
|
Thanks for the PR @samit4me ! Great work! 👍 |
|
Wow that was quick, thanks. |
|
@samit4me Congrats on the PR! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reducer is now pure because the Date is passed as an argument.
This change makes testing the ActionCreators more difficult as the date needs to be mocked, so the date is being mocked using mockdate. I've tried to mock using babel-plugin-rewire but ran into issues regarding named exports which seem to be related to this issue.