Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capitalization of "Bigtable". #522

Merged
merged 1 commit into from
Jul 31, 2017
Merged

Fix capitalization of "Bigtable". #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/chunk/gcp/instrumentation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ import (
var bigtableRequestDuration = prometheus.NewHistogramVec(prometheus.HistogramOpts{
Namespace: "cortex",
Name: "bigtable_request_duration_seconds",
Help: "Time spent doing BigTable requests.",
Help: "Time spent doing Bigtable requests.",

// BigTable latency seems to range from a few ms to a few sec and is
// Bigtable latency seems to range from a few ms to a few sec and is
// important. So use 8 buckets from 128us to 2s.
Buckets: prometheus.ExponentialBuckets(0.000128, 4, 8),
}, []string{"operation", "status_code"})
Expand Down
8 changes: 4 additions & 4 deletions pkg/chunk/gcp/storage_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ type Config struct {

// RegisterFlags adds the flags required to config this to the given FlagSet
func (cfg *Config) RegisterFlags(f *flag.FlagSet) {
f.StringVar(&cfg.project, "bigtable.project", "", "BigTable project ID.")
f.StringVar(&cfg.instance, "bigtable.instance", "", "BigTable instance ID.")
f.StringVar(&cfg.project, "bigtable.project", "", "Bigtable project ID.")
f.StringVar(&cfg.instance, "bigtable.instance", "", "Bigtable instance ID.")
}

// storageClient implements chunk.storageClient for GCP.
Expand Down Expand Up @@ -116,7 +116,7 @@ func (s *storageClient) QueryPages(ctx context.Context, query chunk.IndexQuery,
}

return table.ReadRows(ctx, rowRange, func(r bigtable.Row) bool {
// BigTable doesn't know when to stop, as we're reading "until the end of the
// Bigtable doesn't know when to stop, as we're reading "until the end of the
// row" in DynamoDB. So we need to check the prefix of the row is still correct.
if !strings.HasPrefix(r.Key(), query.HashValue+separator) {
return false
Expand All @@ -125,7 +125,7 @@ func (s *storageClient) QueryPages(ctx context.Context, query chunk.IndexQuery,
}, bigtable.RowFilter(bigtable.FamilyFilter(columnFamily)))
}

// bigtableReadBatch represents a batch of rows read from BigTable. As the
// bigtableReadBatch represents a batch of rows read from Bigtable. As the
// bigtable interface gives us rows one-by-one, a batch always only contains
// a single row.
type bigtableReadBatch bigtable.Row
Expand Down