Migrating from go-kit/kit/log to the slimmer go-kit/log #4421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannykopping
force-pushed
the
dannykopping/go-kit
branch
from
b9e85db to
8b48d94
Compare
Signed-off-by: Danny Kopping <[email protected]>
dannykopping
force-pushed
the
dannykopping/go-kit
branch
from
8b48d94 to
5fdf93c
Compare
added 2 commits
September 14, 2021 09:57
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
pracucci
approved these changes
Sep 29, 2021
| @@ -107,3 +107,20 @@ func CheckFatal(location string, err error) { | |||
| os.Exit(1) | |||
| } | |||
| } | |||
|
|
|||
| // TODO(dannyk): remove once weaveworks/common updates to go-kit/log | |||
There was a problem hiding this comment.
Could you open a PR there too, please?
This was referenced Oct 9, 2021
cristiangreco
added a commit
to grafana/cortex-tools
that referenced
this pull request
Nov 3, 2021
For consistency with Cortex and Prometheus, see - cortexproject/cortex#4421 - prometheus/prometheus#8927
srijan55
pushed a commit
to srijan55/cortex
that referenced
this pull request
Nov 26, 2021
…t#4421) * Migrating from go-kit/kit/log to the slimmer go-kit/log Signed-off-by: Danny Kopping <[email protected]> * Appeasing the linter Signed-off-by: Danny Kopping <[email protected]> * Fixing tests where log lines are produced with different label orders Signed-off-by: Danny Kopping <[email protected]> Signed-off-by: Manish Kumar Gupta <[email protected]>
simonswine
pushed a commit
to grafana/e2e
that referenced
this pull request
Jan 13, 2022
…t/cortex#4421) * Migrating from go-kit/kit/log to the slimmer go-kit/log Signed-off-by: Danny Kopping <[email protected]> * Appeasing the linter Signed-off-by: Danny Kopping <[email protected]> * Fixing tests where log lines are produced with different label orders Signed-off-by: Danny Kopping <[email protected]>
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
…t#4421) * Migrating from go-kit/kit/log to the slimmer go-kit/log Signed-off-by: Danny Kopping <[email protected]> * Appeasing the linter Signed-off-by: Danny Kopping <[email protected]> * Fixing tests where log lines are produced with different label orders Signed-off-by: Danny Kopping <[email protected]> Signed-off-by: Alvin Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR aims to align Cortex with Prometheus (see prometheus/prometheus#8927) in its use of
go-kit's logger.go-kit/kit/logwas split out intogo-kit/log, and that's all we use ofgo-kitostensibly.Note: I had to update some tests since logs get produced with labels in a different order. I think these logs are coming from the vendored Thanos code in the compactor, which may explain why they're ordered differently.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]