Extend alertstore to support read/write of clusterpb.FullState. #4020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesg
force-pushed
the
am-store-2
branch
2 times, most recently
from
e3569fd to
1cbf562
Compare
Required to support the work for ring-based/sharding replication. Due to the underlying `clusterpb.FullState` type being an upstream type defined in alertmanager, it is wrapped in a separate message type (`alertspb.FullStateDesc`). This can be used to cope with backwards incompatible changes to the upstream data format, if ever necessary. Assuming we want to store the state alongside the existing state for the alertmanager, then it makes sense to extend the alertstore. This avoids having to plumb through a different storage widget or configuration. The slight complication is that the existing store uses an object path of `<prefix>/<user>`, so we have to use a different prefix in order to use the desired object path of `<prefix>/<user>/<object>`. Signed-off-by: Steve Simpson <[email protected]>
pracucci
approved these changes
Mar 29, 2021
Signed-off-by: Steve Simpson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Extend alertstore to support read/write of clusterpb.FullState.
Required to support the work for ring-based/sharding replication.
Due to the underlying
clusterpb.FullStatetype being an upstream typedefined in alertmanager, it is wrapped in a separate message type
(
alertspb.FullStateDesc). This can be used to cope with backwardsincompatible changes to the upstream data format, if ever necessary.
Assuming we want to store the state alongside the existing state for the
alertmanager, then it makes sense to extend the alertstore. This avoids
having to plumb through a different storage widget or configuration.
The slight complication is that the existing store uses an object path
of
<prefix>/<user>, so we have to use a different prefix in order touse the desired object path of
<prefix>/<user>/<object>.Checklist
Documentation addedCHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]