Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added query-tee to the list of released binaries #2761

Merged

Conversation

pracucci
Copy link
Contributor

What this PR does:
We're currently releasing only the cortex binaries. Since we've got few users running the query-tee too, I would like to also build and release query-tee binaries along with Cortex releases.

Which issue(s) this PR fixes:
N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is it worth adding a changelog entry?

@pracucci
Copy link
Contributor Author

Is it worth adding a changelog entry?

I'm not sure, because it's an internal tooling used for releases and people will just see the binary in the next Cortex release.

@pracucci pracucci merged commit b64dabe into cortexproject:master Jun 22, 2020
@pracucci pracucci deleted the release-query-tee-binaries-too branch June 22, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants