Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove AWS auto-scaler code #1379

Closed
bboreham opened this issue May 9, 2019 · 3 comments · Fixed by #2328
Closed

remove AWS auto-scaler code #1379

bboreham opened this issue May 9, 2019 · 3 comments · Fixed by #2328
Labels
component/aws
Milestone
v1

Comments

@bboreham
Copy link
Contributor

bboreham commented May 9, 2019

Currently we have two ways to auto-scale DynamoDB - using AWS' facility and using Cortex "metrics-based" code.
As described at #735 the AWS version never worked satisfactorily for Weaveworks.

This issue is to gather feedback for removing support for AWS autoscaling, thus simplifying the codebase. Most of the implementation is in one file.

Not much would change for end-users who are not using the feature. Most of the flags were re-used for metrics-based scaling.
@tomwilkie
Copy link
Contributor

+1 we don't use it, so I'd say go for it.

@csmarchbanks
Copy link
Contributor

I agree to get rid of it. I just spun up my first AWS cortex deployment, and figuring out autoscaling took the most amount of time. Having just one way to do it would be much appreciated.

@khaines
Copy link
Contributor

khaines commented May 21, 2019

+1 for removal. Once we switched to the metrics based autoscaling, I've never looked back.

The AWS based one is really good at scaling your bill up though :)

@bboreham bboreham changed the title RFC: remove AWS auto-scaler code remove AWS auto-scaler code Jan 19, 2020
@bboreham bboreham mentioned this issue Jan 19, 2020
Closed
@tomwilkie tomwilkie added this to the v1 milestone Feb 27, 2020
@gouthamve gouthamve mentioned this issue Mar 25, 2020
Merged
1 task
tomwilkie pushed a commit to gouthamve/cortex that referenced this issue Mar 28, 2020
@gouthamve @tomwilkie
Remove AWS based autoscaler code
077d66b 
We still support metrics based autoscaling.

Fixes cortexproject#1379

Signed-off-by: Goutham Veeramachaneni <[email protected]>
gouthamve added a commit that referenced this issue Mar 30, 2020
@gouthamve @tomwilkie
Remove AWS based autoscaler code (#2328)
63c426b 
* Remove AWS based autoscaler code

We still support metrics based autoscaling.

Fixes #1379

Signed-off-by: Goutham Veeramachaneni <[email protected]>

* Remove unused function.

Signed-off-by: Tom Wilkie <[email protected]>

* Remove unused vendor code.

Signed-off-by: Tom Wilkie <[email protected]>

* Fix bad rebase.

Signed-off-by: Tom Wilkie <[email protected]>

Co-authored-by: Tom Wilkie <[email protected]>
cyriltovena pushed a commit to cyriltovena/loki that referenced this issue Jun 11, 2021
@gouthamve @tomwilkie
Remove AWS based autoscaler code (grafana#2328)
6413dbc 
* Remove AWS based autoscaler code

We still support metrics based autoscaling.

Fixes cortexproject/cortex#1379

Signed-off-by: Goutham Veeramachaneni <[email protected]>

* Remove unused function.

Signed-off-by: Tom Wilkie <[email protected]>

* Remove unused vendor code.

Signed-off-by: Tom Wilkie <[email protected]>

* Fix bad rebase.

Signed-off-by: Tom Wilkie <[email protected]>

Co-authored-by: Tom Wilkie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/aws
Projects
None yet
Milestone
v1
Development

Successfully merging a pull request may close this issue.

Remove AWS based autoscaler code gouthamve/cortex
5 participants
@tomwilkie @khaines @csmarchbanks @jtlisi @bboreham