FIX TEST Multiple files cross-contamination extraction #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The reason for the bug was:
fileExtractor.ts
lines7-16
).table.rows
. This doesn't get cleared, therefore if multiple files for the same extractor type are used, they all feed into the same array and the data is shared.Current suggested solution:
dumpExtractorData
inFileExtractor
. This empties all the extractors'.table.rows
.At the moment this might be enough unless we want to have some sort of data separation in this sense on the client side. Do we expect users to provide multiple zip files for the same extractor type? And if we do, do we want to keep the data in separate sqlite databases?