Fix Rustflags test #203
Merged
Fix Rustflags test #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrosion selects Debug mode if Debug mode or nothing is specified and Release mode for all other CMake build types. This commit fixes the rustflags test for other build modes, where Corrosion selected the release build mode for cargo. Selecting a custom cargo profile will still cause issues for this test, but there is not really a reason to do that when building corrosion, so this can still be improved later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrosion selects Debug mode if Debug mode or nothing is specified and Release mode
for all other CMake build types.
This commit fixes the rustflags test for other build modes, where
Corrosion selected the release build mode for cargo.
Selecting a custom cargo profile will still cause issues for this test,
but there is not really a reason to do that when building corrosion,
so this can still be improved later.