Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(97): version table does not require defaults #98

Merged
merged 1 commit into from
Oct 13, 2023
Merged

fix(97): version table does not require defaults #98

merged 1 commit into from
Oct 13, 2023

Conversation

indiVar0508
Copy link
Contributor

since version table store entries at any point in time in DB of original table, we execute insert statements for them, now there are scenerios where if a user is setting a value explicitly as None in original table, version table is still picking default value causing inconsistency b/w version table and original table

@indiVar0508 indiVar0508 linked an issue Sep 16, 2023 that may be closed by this pull request
Version Tables picking default value for update operations #97
Closed
@coveralls
Copy link

coveralls commented Sep 16, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6506478615

  • 27 of 27 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 97.764%
Totals Coverage Status
Change from base Build 6506453829: 0.01%
Covered Lines: 4968
Relevant Lines: 5015
💛 - Coveralls

@indiVar0508
fix(97): version table does not require defaults
1d761ab 
since version table store entries at any point in time in DB of
original table, we execute insert statements for them, now there
are scenerios where if a user is setting a value explicitly as
None in original table, version table is still picking default
value causing inconsistency b/w version table and original table
@indiVar0508 indiVar0508 merged commit 9e232f7 into master Oct 13, 2023
11 checks passed
@indiVar0508 indiVar0508 deleted the fix_97 branch October 13, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saumzzz saumzzz saumzzz approved these changes

@aditya051293 aditya051293 aditya051293 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version Tables picking default value for update operations
4 participants
@indiVar0508 @coveralls @aditya051293 @saumzzz