support sqla 2.0 #89
Merged
support sqla 2.0 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indiVar0508
force-pushed
the
add_72
branch
5 times, most recently
from
99055f4 to
5a42792
Compare
indiVar0508
force-pushed
the
add_72
branch
4 times, most recently
from
0ab6e49 to
4d2b7cf
Compare
Pull Request Test Coverage Report for Build 6779158147Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
ran all tests with flag SQLA_20_WARNING=1 and resolved all warning
broadly below mentioned warnings are resolved
1. select query syntax changed to leverage positional args and
select_from
2. use session.get_transaction() instead of session.transaction
3. use row._mapping[..] instead of row[..] to keep it compatible
with sqla2.0
4. use sa.text() for string based queries
5. use session.get instead of session.Query.get(
6. import declarative_base from sa.orm instead of
sa.ext.declarative_base
7. use connection.begin() to execute queries from metadata
8. use versions.all()[-1] instead of versions[-1] as negative
indexing support is deprecated
9. cascade_backref support is to be dropped from 2.0 so add
object before merging
10. removed pin for <2.0
11. use sa.orm.Mapper instead of sa.orm.mapper
12. concreteInheritedProperty doesn't have active_history
used what is done for sqla-continuum
13. use savepoint to rollback
ref: kvesteri/sqlalchemy-utils#719 there is some issue b/w sqla-utils and sqla==2.0.22 so excuding sqla>=2.0.22 for now. `TypeError: __init__() missing 1 required positional argument: 'dispatch'`
from sqla 2.0, it will not explicitly add start=1 on queries generated for sequence which impacts mssql queries, so passing start=1 for all DB(s) ref: https://docs.sqlalchemy.org/en/20/dialects/mssql.html#sequence-support
AbdealiLoKo
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.