Enable Exclusive Transactions. (#79)

Without this, the Timeout value does nothing.
coronabytes · Nov 13, 2024 · 089ecad · 089ecad
1 parent f2cd9bd
commit 089ecad
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 4 deletions.
diff --git a/Core.Arango.Tests/TransactionTest.cs b/Core.Arango.Tests/TransactionTest.cs
@@ -22,8 +22,9 @@ public async Task StreamTransaction(string serializer)
             {
                 Collections = new ArangoTransactionScope
                 {
-                    Write = new List<string> {"test"}
-                }
+                    Exclusive = ["test"]
+                },
+                AllowImplicit = false
             });
 
             await Arango.Document.CreateManyAsync(t1, "test", new List<Entity>
@@ -41,8 +42,9 @@ public async Task StreamTransaction(string serializer)
             {
                 Collections = new ArangoTransactionScope
                 {
-                    Write = new List<string> {"test"}
-                }
+                    Exclusive = ["test"]
+                },
+                AllowImplicit = false
             });
 
             await Arango.Document.CreateManyAsync(t2, "test", new List<Entity>

diff --git a/Core.Arango/Core.Arango.xml b/Core.Arango/Core.Arango.xml
@@ -5223,6 +5223,7 @@
                 An optional numeric value that can be used to set a timeout for waiting on collection locks.
                 If not specified, a default value will be used.
                 Setting lockTimeout to 0 will make ArangoDB not time out waiting for a lock.
+                This is only meaningful when using exclusive transaction locks.
             </summary>
         </member>
         <member name="P:Core.Arango.Protocol.ArangoTransaction.Params">
@@ -5250,6 +5251,11 @@
                 Collections to write to
             </summary>
         </member>
+        <member name="P:Core.Arango.Protocol.ArangoTransactionScope.Exclusive">
+            <summary>
+                Collections to write to with an exclusive lock
+            </summary>
+        </member>
         <member name="T:Core.Arango.Protocol.ArangoUpdateResult`1">
             <summary>
                 Arango document update result

diff --git a/Core.Arango/Protocol/ArangoTransaction.cs b/Core.Arango/Protocol/ArangoTransaction.cs
@@ -55,6 +55,7 @@ public class ArangoTransaction
         ///     An optional numeric value that can be used to set a timeout for waiting on collection locks.
         ///     If not specified, a default value will be used.
         ///     Setting lockTimeout to 0 will make ArangoDB not time out waiting for a lock.
+        ///     This is only meaningful when using exclusive transaction locks.
         /// </summary>
         [JsonPropertyName("lockTimeout")]
         [JsonProperty(PropertyName = "lockTimeout", NullValueHandling = NullValueHandling.Ignore)]

diff --git a/Core.Arango/Protocol/ArangoTransactionScope.cs b/Core.Arango/Protocol/ArangoTransactionScope.cs
@@ -24,5 +24,14 @@ public class ArangoTransactionScope
         [JsonProperty(PropertyName = "write", NullValueHandling = NullValueHandling.Ignore)]
         [System.Text.Json.Serialization.JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
         public List<string> Write { get; set; }
+
+
+        /// <summary>
+        ///     Collections to write to with an exclusive lock
+        /// </summary>
+        [JsonPropertyName("exclusive")]
+        [JsonProperty(PropertyName = "exclusive", NullValueHandling = NullValueHandling.Ignore)]
+        [System.Text.Json.Serialization.JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
+        public List<string> Exclusive { get; set; }
     }
 }